Add email social sharing provider #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Roeland Jago Douma <[email protected]>
MariusBluem
approved these changes
Mar 27, 2017
Member
MariusBluem
left a comment
MariusBluem
left a comment
There was a problem hiding this comment.
👍 ... Should make some guys happy: nextcloud/server#2357 😜 @schiessle
schiessle
reviewed
Mar 31, 2017
| (function() { | ||
| var email = new OC.Share.Social.Model({ | ||
| key: 'email', | ||
| url: 'mailto:?subject=I shared a file with yout&body={{reference}}', |
Member
There was a problem hiding this comment.
I would suggest to translate the subject
Member
Author
There was a problem hiding this comment.
Mmm fair enough but then we have to setup transifex for this app. I suggest to get it in now. And fix it later ;)
Member
|
I just tried it. When I click on the "share to mail" button my mail client gets started but instead of a mail composer it open a empty browser window along with the mail client... |
Member
Author
|
mmmm I think that is the server part (that actually opens a window)... maybe we need some magic there... It might also be browser dependant |
Signed-off-by: Roeland Jago Douma <[email protected]>
MorrisJobke
approved these changes
Apr 20, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.